Import austraits #177
Open
Import austraits #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update DESCRIPTION file to import austraits functions from development branch - to begin testing removing the functions from traits.build and importing them
Remove traits.build functions `util_df_to_list`, `util_list_to_df1` and `util_list_to_df2` replacing them with the austraits equivalents - beginning with `convert` instead of `util`
Remove `build_combine` as a function in traits.build, instead using its replacement in austraits, `bind_databases`
tests passing!
install austraits from master
dfalster
reviewed
Nov 19, 2024
dfalster
requested changes
Nov 19, 2024
remove tests that are commented out
…, added deprecation warning, reexported austraits::convert_list_to_df1
… reexported austraits::convert_list_to_df2
…ed austraits::convert_list_to_df2
dfalster
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of functions from traits.build to accompany release of austraits 3.0
util_df_to_listandutil_list_to_dfare now sourced fromaustraits(asconvert_df_to_listandconvert_list_to_df)build_combineis now replaced by austraits::bind_databasesplot_trait_distribution_beeswarm,trait_pivot_longerandtrait_pivot_widerhad been in both packages and have now been removed from traits.buildflatten_databaseis a replacement fordatabase_create_combined_table, which was still on a branchutils.R, the functions that have been moved and renamed are also assigned their old names, to ensure that the names included in our Eco Informatics publication are still "valid" and that people using old remake/build.R files are not inconvenienced by these changes