Update testdata.R #134
Merged
Update testdata.R #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes to tests described in #133
dfalster
approved these changes
Nov 16, 2023
fix typo
add notes to explain commented out tests
- commenting out more of taxonomic_updates tests - for fields like basis_of_record, splitting input into `words` since fixed values sometimes multiple terms
- add `unknown` to list of allowed values for various variables
…s.build into tests-temp-fix
more stringr splits
…s.build into tests-temp-fix
reinstate some taxonomy tests I think some others are fixed as well, but result in lots more metadata file changes - that don't affect output
…s.build into tests-temp-fix
…s.build into tests-temp-fix
…vations` for `taxon_name`
…dates bringing back online tests to ensure no unneeded info in taxonomic_updates
…s.build into tests-temp-fix
- Also fix message for testing dataframe column names
* fixed taxonomic_updates table to include `aligned_name_taxon_id`, `aligned_name_taxonomic_status` * changed `process_standardise_names` to not capitalise an "x" indicating a hybrid taxon * some minor edits to schema * fix reports to work with new taxon scheme
Merged
dfalster
added a commit
that referenced
this pull request
Nov 19, 2023
* *Update testdata.R (#134) - fixes to tests described in #133 - for fields like basis_of_record, splitting input into `words` since fixed values sometimes multiple terms - add "unknown" to lists of allowed values * combined with fixes to metadata files in austraits.build * Add less/greater than or equal signs to exceptions for metadata * fixed taxonomic_updates table to include `aligned_name_taxon_id`, `aligned_name_taxonomic_status` * changed `process_standardise_names` to not capitalise an "x" indicating a hybrid taxon * some minor edits to schema * report edits - fix reports to work with new taxon scheme - Remove bins and ranges from plot_trait_distribution_beeswarm --------- Co-authored-by: yangsophieee <[email protected]> Co-authored-by: Sophie Yang <[email protected]> Co-authored-by: Elizabeth Wenk <[email protected]>
dfalster
added a commit
that referenced
this pull request
Nov 19, 2023
* Update testdata.R (#134) - fixes to tests described in #133 - for fields like basis_of_record, splitting input into `words` since fixed values sometimes multiple terms - add "unknown" to lists of allowed values * combined with fixes to metadata files in austraits.build * Add less/greater than or equal signs to exceptions for metadata * fixed taxonomic_updates table to include `aligned_name_taxon_id`, `aligned_name_taxonomic_status` * changed `process_standardise_names` to not capitalise an "x" indicating a hybrid taxon * some minor edits to schema * report edits - fix reports to work with new taxon scheme - Remove bins and ranges from plot_trait_distribution_beeswarm --------- Co-authored-by: yangsophieee <[email protected]> Co-authored-by: Sophie Yang <[email protected]> Co-authored-by: Elizabeth Wenk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes to tests described in #133