Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More dataset tests #132

Merged
merged 44 commits into from
Nov 16, 2023
Merged

More dataset tests #132

merged 44 commits into from
Nov 16, 2023

Conversation

yangsophieee
Copy link
Collaborator

@yangsophieee
Merge branches
a1c2cf5
@yangsophieee
Add another context test
f6c745a
@yangsophieee
Add more tests and todo's
ebbeace
@yangsophieee
Merge with other branch
8ae27c7
@yangsophieee
Move stuff out of this branch
2841c12
@yangsophieee
Move location of location tests
49023d0
@yangsophieee
Remove redundant code
a9abbb1
@yangsophieee
Add value_type and basis_of_value to required fields of traits
6afb27e
@yangsophieee
Add tests for allowed metadata values
36b2c3e
@yangsophieee
Update comments
4b0e343
@yangsophieee
Add tests for checking duplicate find values in taxonomic_updates…
154ff12 
… and `exclude_observations` and `substitutions`
@yangsophieee
Modify Test_2023_5
97f8160
@yangsophieee
Add new test dataset
c08763a
@yangsophieee
Edit failure messages
3db444b
@yangsophieee
Add functionality to specify folder when checking custom R code
a5f7b42 
- Mainly for testing purposes
@yangsophieee
Fix bug with dataset_test
374880f
@yangsophieee
Fix dataset_test bugs
d00f1e7
@yangsophieee
Tidy metadata files with dataset_test
d87d744
@yangsophieee
Add Test_2023_5 output files
b115a0d
@yangsophieee
Fix bin values in metadata
e931f3b
@yangsophieee
Update taxon_list-orig.csv
a53b655
@yangsophieee
Add unit conversions for days to months and vice versa
6de5303
@yangsophieee
Add expected output
a940bd6
@yangsophieee
Update Test_2023_5
86f013c
@yangsophieee
Add tests for Test Dataset 5
2175339
@yangsophieee
Update expected output
abcd0cf
@yangsophieee
Update Test_2023_5
a23fb15
@yangsophieee
Add Test_2023_6
9ad18b1
@yangsophieee
Update test to accept latitude and longitude ranges
e537031
@yangsophieee
Add expected output for Test_2023_6
70e324e
ehwenk
ehwenk approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@ehwenk ehwenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over the changes to the R files carefully - but can't be certain I've checked everything in the tests

@yangsophieee yangsophieee merged commit c706804 into develop Nov 16, 2023
3 checks passed
@yangsophieee yangsophieee deleted the more_dataset_tests branch November 16, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehwenk ehwenk ehwenk approved these changes

@dfalster dfalster Awaiting requested review from dfalster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dataset_test for checking duplicate rows in contexts table
3 participants
@yangsophieee @ehwenk @dfalster