New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend refactor #425

Merged

xlauko merged 17 commits into master from module-attrs

Oct 25, 2023

Member

xlauko commented Oct 24, 2023

obliterate vast-cc in favor of vast-front
refactor codegen interface and make its builder more flexible
add source language attr to module
fix module location
fix bogus type caching
fix vast-front missing return generation

xlauko added 17 commits

October 24, 2023 20:28


          core: Introduce source language attr.

6e27483


          cg: Emit language attribute for vast modules.

5a92fe7


          cg: Fix duplicit global emition.

dc526e3


          cg: Emit function declarations.

cb249dd


          cg: Remove bogus type caching.

2305f43


          cg: Simplify type conversion and delegate it to single visitor.

0bd572f


          cg: Allow thread local global generation.

8cf5201


          cg: Force emition of all declarations.

88b57c2


          cg: Refactor visitor instantiation to be more consistent with vast co…

52d67be

…de style.


          cg: Deal with missing and implicit function returns.

f48f91f


          test: Update vast-front invokes.

75ba101


          cg: Temporarily turn off source attr.

a7f8dee


          cg: Simplify codegen naming.

ee43e62


          cg: Set correct module location and name.

38c77aa


          test: Check module name.

99e0b27


          treewide: Obliterate vast-cc translator remains.

016a281


          cg: Add option to emit locations.

xlauko added enhancement frontend labels

xlauko requested a review from lkorenc

October 24, 2023 18:37

xlauko self-assigned this

Contributor

github-actions bot commented Oct 24, 2023

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 28 file(s) not formatted

include/vast/CodeGen/CodeGen.hpp
include/vast/CodeGen/CodeGenAttrVisitor.hpp
include/vast/CodeGen/CodeGenBuilder.hpp
include/vast/CodeGen/CodeGenContext.hpp
include/vast/CodeGen/CodeGenDeclVisitor.hpp
include/vast/CodeGen/CodeGenDriver.hpp
include/vast/CodeGen/CodeGenMeta.hpp
include/vast/CodeGen/CodeGenScope.hpp
include/vast/CodeGen/CodeGenStmtVisitor.hpp
include/vast/CodeGen/CodeGenTypeVisitor.hpp
include/vast/CodeGen/CodeGenVisitor.hpp
include/vast/CodeGen/CodeGenVisitorBase.hpp
include/vast/CodeGen/CodeGenVisitorLens.hpp
include/vast/CodeGen/DefaultVisitor.hpp
include/vast/CodeGen/FallBackVisitor.hpp
include/vast/CodeGen/Generator.hpp
include/vast/CodeGen/UnreachableVisitor.hpp
include/vast/CodeGen/UnsupportedVisitor.hpp
include/vast/Util/Common.hpp
lib/vast/CodeGen/CodeGenDriver.cpp
lib/vast/CodeGen/CodeGenFunction.cpp
lib/vast/CodeGen/Generator.cpp
lib/vast/Frontend/GenAction.cpp
tools/vast-repl/codegen.cpp

clang-tidy reports: 4 concern(s)

include/vast/CodeGen/CodeGenContext.hpp

/include/vast/CodeGen/ScopeContext.hpp:46:9: error: [clang-diagnostic-error]

use of undeclared identifier 'gap'
```
   46 |         gap::generator< action_t > deferred() {
      |         ^
```
/include/vast/CodeGen/ScopeContext.hpp:48:17: error: [clang-diagnostic-error]

std::coroutine_traits type was not found; include before defining a coroutine
```
   48 |                 co_yield deferred_codegen_actions.front();
      |                 ^
```
include/vast/CodeGen/DefaultVisitor.hpp

/include/vast/Dialect/Meta/MetaDialect.hpp:17:10: error: [clang-diagnostic-error]

'vast/Dialect/Meta/MetaDialect.h.inc' file not found
```
   17 | #include "vast/Dialect/Meta/MetaDialect.h.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
lib/vast/CodeGen/Generator.cpp

/include/vast/Dialect/HighLevel/HighLevelDialect.hpp:19:10: error: [clang-diagnostic-error]

'vast/Dialect/HighLevel/HighLevelDialect.h.inc' file not found
```
   19 | #include "vast/Dialect/HighLevel/HighLevelDialect.h.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Have any feedback or feature suggestions? Share it here.

lkorenc approved these changes

View reviewed changes

xlauko merged commit 0b9023f into master

4 checks passed

xlauko deleted the module-attrs branch

October 25, 2023 10:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels