Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Semgrep CI with custom Semgrep rules dirs/repos #34

Merged
merged 10 commits into from
May 3, 2024
Merged

Update Semgrep CI with custom Semgrep rules dirs/repos #34

merged 10 commits into from
May 3, 2024

Conversation

ahpaleus
Copy link
Member

Closes: #32

@ahpaleus ahpaleus requested a review from fcasal April 26, 2024 13:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-03 15:36 UTC

@ahpaleus ahpaleus requested a review from fegge as a code owner April 26, 2024 13:24
elopez
elopez reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a few comments, but this looks good overall 👍

content/docs/static-analysis/semgrep/20-ci.md Outdated Show resolved Hide resolved
content/docs/static-analysis/semgrep/20-ci.md Outdated Show resolved Hide resolved
content/docs/static-analysis/semgrep/20-ci.md Outdated Show resolved Hide resolved
content/docs/static-analysis/semgrep/20-ci.md Outdated Show resolved Hide resolved
content/docs/static-analysis/semgrep/20-ci.md Outdated Show resolved Hide resolved
@fcasal
Copy link
Collaborator

fcasal commented Apr 26, 2024

lgtm after @elopez 's comments are addressed

@ahpaleus ahpaleus merged commit 1e974ce into main May 3, 2024
4 of 5 checks passed
@ahpaleus ahpaleus deleted the ci-semgrep-update branch May 3, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcasal fcasal fcasal left review comments

@elopez elopez elopez left review comments

@fegge fegge Awaiting requested review from fegge fegge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing template on how to add a custom semgrep rule to CI
3 participants
@ahpaleus @fcasal @elopez