Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade theme submodule #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade theme submodule #33

wants to merge 1 commit into from

Conversation

elopez
Copy link
Member

@elopez elopez commented Apr 22, 2024

No description provided.

@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://trailofbits.github.io/testing-handbook-preview/pr-preview/pr-33/
on branch gh-pages at 2024-04-22 14:41 UTC

@elopez elopez marked this pull request as ready for review May 3, 2024 15:46
@elopez elopez requested a review from ahpaleus as a code owner May 3, 2024 15:46
maxammann
maxammann approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff also looks fine: alex-shpak/hugo-book@d5b75f4...f8a0fc4#diff-a22ce72f559279e2b268c61544e9e67d3bec733d98c878c79ea381623539069c

@maxammann
Copy link
Contributor

I got the following error, so this should be high prio:

WARN  deprecated: resources.ToCSS was deprecated in Hugo v0.128.0 and will be removed in a future release. Use css.Sass instead.
WARN  deprecated: .Sites.First was deprecated in Hugo v0.127.0 and will be removed in a future release. Use .Sites.Default instead.
ERROR deprecated: .Site.IsMultiLingual was deprecated in Hugo v0.124.0 and will be removed in Hugo 0.137.0. Use hugo.IsMultilingual instead.

The deperecations originate from the theme

@elopez
Copy link
Member Author

elopez commented Jan 9, 2025

Yeah, we'll have to update the theme and fix a few of our shortcodes if we want to upgrade Hugo. The CI workflow uses a fixed Hugo version though so there's no immediate need to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxammann maxammann maxammann approved these changes

@ahpaleus ahpaleus Awaiting requested review from ahpaleus ahpaleus is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elopez @maxammann