Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar fix #31

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Scrollbar fix #31

merged 6 commits into from
Apr 25, 2024

Conversation

ahpaleus
Copy link
Member

@ahpaleus ahpaleus commented Apr 16, 2024

Before:
image

After (only after hovering the mouse over):
image

@ahpaleus ahpaleus requested a review from elopez as a code owner April 16, 2024 10:20
Copy link

github-actions bot commented Apr 16, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-25 13:19 UTC

@ahpaleus
Copy link
Member Author

@elopez take a look, merge if it's ok

@elopez
Copy link
Member

elopez commented Apr 16, 2024

This doesn't seem to have any effect on Firefox (I guess it's expected, considering that the PR uses nonstandard webkit extensions).

Can we add something with the standard properties so it looks a bit better there as well?

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scrollbars_styling

https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar#adding_a_fallback_for_scrollbar_styles

@ahpaleus
Copy link
Member Author

ahpaleus commented Apr 17, 2024

This doesn't seem to have any effect on Firefox (I guess it's expected, considering that the PR uses nonstandard webkit extensions).

Can we add something with the standard properties so it looks a bit better there as well?

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scrollbars_styling

https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar#adding_a_fallback_for_scrollbar_styles

Thanks! @supports selector(::-webkit-scrollbar) seems to be unsupported in Hugo but I will try to find a workaround :-)

@ahpaleus
Copy link
Member Author

@elopez I am not sure if it is the best way to achieve this (b9cba82), but you can see Firefox/Safari/Chrome:
image

Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good now 👍

@ahpaleus ahpaleus merged commit cc94155 into main Apr 25, 2024
5 checks passed
@ahpaleus ahpaleus deleted the scrollbar-fix branch April 25, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants