Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to SARIF Explorer #25

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Add references to SARIF Explorer #25

merged 2 commits into from
Mar 22, 2024

Conversation

Vasco-jofra
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Mar 22, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-22 12:01 UTC

Copy link
Member

@ahpaleus ahpaleus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@fcasal fcasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahpaleus Slightly orthogonal to this PR: would it make sense to add the copyable commands for the semgrep sarif and vim formats? As a reader, you'll need to run semgrep scan --help and then read all that to find what you are looking for. Leaving the commands there directly to be copied would make it much easier

@ahpaleus
Copy link
Member

lgtm

@ahpaleus Slightly orthogonal to this PR: would it make sense to add the copyable commands for the semgrep sarif and vim formats? As a reader, you'll need to run semgrep scan --help and then read all that to find what you are looking for. Leaving the commands there directly to be copied would make it much easier

Yes!

@Vasco-jofra Vasco-jofra merged commit 545cf1e into main Mar 22, 2024
5 checks passed
@Vasco-jofra Vasco-jofra deleted the VF/sarif-explorer branch March 22, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants