-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cargo workspace #78
Conversation
Updates the requirements on [cryptography](https://github.com/pyca/cryptography) to permit the latest version. Updates `cryptography` to 44.0.0 - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@43.0.0...44.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production dependency-group: python ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Alexis <[email protected]>
There is some issue with the Windows CI build - back to Draft status until resolved (something along with setting |
Signed-off-by: Alexis <[email protected]>
678aebf
to
4e4b08e
Compare
Signed-off-by: William Woodruff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I cleaned up the old lockfiles as well.
It doesn't seem to be affecting the CI, but make dev
produces a strange error for me locally:
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.05s
📦 Built wheel for abi3 Python ≥ 3.9 to /var/folders/k6/zk7vnkms1m73w0vrxjm7b2s40000gn/T/.tmprjlaQs/rfc3161_client-0.0.5-cp39-abi3-macosx_11_0_arm64.whl
✏️ Setting installed package as editable
💥 maturin failed
Caused by: failed to list package files
@DarkaMaul have you seen that before?
Never in my local tests. It seems, it's coming from : fn fix_direct_url(
build_context: &BuildContext,
python: &Path,
install_backend: &InstallBackend,
) -> Result<()> {
println!("✏️ Setting installed package as editable");
let mut cmd = install_backend.make_command(python);
let cmd = cmd.args(["show", "--files", &build_context.metadata23.name]);
debug!("running {:?}", cmd);
let output = cmd.output()?;
ensure!(output.status.success(), "failed to list package files");
... Which runs: uv pip show --files rfc3161-client Maybe the output of this command could help us in understanding what happens? |
Hmm:
|
Ah, this was caused by me being on |
To reduce deduplication between our two rust crates, use a workspace to manage shared dependencies.