UBet specific adaptations #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables logging of control affecting data flow by specifying the --cflog argument to the `instrument-targets` command. Adds support for a new section in the TDAG, adds the instrumentation step and instrumentation callback handlers.
hbrodin
requested review from
surovic and
ESultanik
and removed request for
surovic
surovic
reviewed
May 24, 2023
There was a problem hiding this comment.
Disclaimer: I haven't read the PR in full. I got to the instrumentation pass and cflog tdag section. It seems to me like there's a significant overlap between this instrumentation and the existing function tracing, namely with the function entry and exit logging. Am I missing something?
| _extract_bitcode(target_path, bc_path) | ||
| _optimize_bitcode(bc_path, bc_path) | ||
| if args.cflog: |
There was a problem hiding this comment.
nitpick: I would just overwrite bc_path here with <path>.preopt.bc or <path>opt.bc and make a single _optimize_bitcode(...) call.
surovic
reviewed
May 24, 2023
surovic
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UBet uses a tainted control flow log to get the data needed to detect variability bugs. This is the instrumentation changes that were done to support it.
To enable the
Control Affecting Dataflowlog, invoke theinstrument-targetscommand using--cflogin addition to the--taintand/or--ftracearguments.There is still some overlap between the features but we can unify that over time. This PR should be non-intrusive in that it shouldn't impact any of the existing functionality.