Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: expand examples_do_not_have_gitignore to check more files/paths #1461

Merged
merged 4 commits into from
Dec 29, 2024
Merged

test: expand examples_do_not_have_gitignore to check more files/paths #1461

merged 4 commits into from
Dec 29, 2024

Conversation

0x471
Copy link
Contributor

@0x471 0x471 commented Dec 28, 2024

@0x471 0x471 requested a review from smoelius as a code owner December 28, 2024 20:14
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

smoelius
smoelius reviewed Dec 28, 2024
View reviewed changes
examples/src/lib.rs Outdated Show resolved Hide resolved
@smoelius smoelius linked an issue Dec 29, 2024 that may be closed by this pull request
Expand examples_do_not_have_gitignore test #1417
Closed
@smoelius
Copy link
Collaborator

If you can just make the lints happy, I think this PR should be good to go.

@0x471
Copy link
Contributor Author

0x471 commented Dec 29, 2024

Any ideas on why these two tests are failing? They passed in the previous CI run. Appreciate any insights. @smoelius

@smoelius
Copy link
Collaborator

Neither are related to your changes.

The fix test failure appears to be an instance of this known problem: #1353 (comment)

The supply_chain test let's me know when my dependencies' publishers change, and some of them did recently.

I'm going to rebase your branch and I expect everything to be green after that.

@smoelius smoelius force-pushed the test/example-gitignore branch from f68060c to 26f242b Compare December 29, 2024 17:08
@0x471
Copy link
Contributor Author

0x471 commented Dec 29, 2024

Thanks, looks like ready to go!

@smoelius
Copy link
Collaborator

Thanks a lot for doing this!

@smoelius smoelius added this pull request to the merge queue Dec 29, 2024
Merged via the queue into trailofbits:master with commit 0bc9bb7 Dec 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoelius smoelius smoelius left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand examples_do_not_have_gitignore test
3 participants
@0x471 @CLAassistant @smoelius