Expand examples_do_not_have_gitignore test

[smoelius]

To examples_do_not_contain_forbidden_paths or something similar:

dylint/examples/src/lib.rs

Line 101 in dad4f73

fn examples_do_not_have_gitignore() {

The test should continue check that the following is not in any example subdirectory:

• .gitignore

The test should additionally check that the following are not in any non-root subdirectory of the general, supplementary, or restriction subdirectories:

• .cargo/config.toml
• rust-toolchain

However, the test should allow those files to exist in the experimental and testing subdirectories, e.g., like here:

• https://github.com/trailofbits/dylint/blob/master/examples/experimental/derive_opportunity/.cargo/config.toml
• https://github.com/trailofbits/dylint/blob/master/examples/testing/straggler/rust-toolchain

[0x471]

Hi, can I work on this issue? @smoelius

[smoelius]

@0x471 Yes, please do!

[smoelius]

I just clarified the issue description a little bit. I think the changes are small. Hopefully, you agree.

[0x471]

Thank you for the details, feel free to check the PR!

it seems the test is currently failing because there’s a rust-toolchain file in the general examples folder. According to the issue description, this file shouldn’t be there.

How do you suggest proceeding with this?

[smoelius]

it seems the test is currently failing because there’s a rust-toolchain file in the general examples folder.

That's okay, actually.

In fact, my reason for wanting to expand the test is to ensure that no file in a subdirectory overrides those.

I'm not sure the easiest/best way to suggest allowing exceptions for the roots of the general, supplementary, and restriction subdirectories. Can I leave it to you to decide?

P.S. I just tweaked the description again. Sorry for being imprecise.

[0x471]

I modified the test accordingly, added a new array for root directories with exceptions: f49cf23