inconsistent_qualification: don't lint in macro definitions

trailofbits · Jun 24, 2024 · c3a4838 · c3a4838
1 parent aebc37f
commit c3a4838
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/examples/restriction/inconsistent_qualification/src/lib.rs b/examples/restriction/inconsistent_qualification/src/lib.rs
@@ -61,11 +61,12 @@ impl<'tcx> LateLintPass<'tcx> for InconsistentQualification {
     fn check_path(&mut self, cx: &LateContext<'tcx>, path: &Path<'tcx>, hir_id: HirId) {
         // smoelius: On the Dylint source code itself, simply checking
         // `path.span.in_derive_expansion()` isn't sufficient to prevent false positives.
-        if !cx
-            .tcx
-            .hir()
-            .parent_iter(hir_id)
-            .any(|(hir_id, _)| cx.tcx.hir().span(hir_id).in_derive_expansion())
+        if !path.span.from_expansion()
+            && !cx
+                .tcx
+                .hir()
+                .parent_iter(hir_id)
+                .any(|(hir_id, _)| cx.tcx.hir().span(hir_id).in_derive_expansion())
             && let node = cx.tcx.hir_node(hir_id)
             && !matches!(
                 node,

diff --git a/examples/restriction/inconsistent_qualification/ui/main.rs b/examples/restriction/inconsistent_qualification/ui/main.rs
@@ -131,3 +131,13 @@ mod underscore_import {
         }
     }
 }
+
+macro_rules! check_ld_preload {
+    () => {
+        assert_eq!(Err(std::env::VarError::NotPresent), var("LD_PRELOAD"));
+    };
+}
+
+fn foo() {
+    check_ld_preload!();
+}