-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
64-bit compatibility #67
base: master
Are you sure you want to change the base?
Changes from all commits
8ed7176
bad29f0
6af8b50
5d31532
dc649dd
5117061
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
add_compile_options( -fno-exceptions -fno-rtti -DCPLUSPLUS ) | ||
set( SERVICE_ID "00119" ) | ||
set( AUTHOR_ID "KPRCA" ) | ||
add_compile_options( -Oz -g ) | ||
add_compile_options( -Os -g ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm curious, why does this need changed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apparantly, -Oz is a MacOS version of -Os ¯_(ツ)_/¯ |
||
set( VULN_COUNT "1" ) | ||
buildCB() |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
add_compile_options( -fno-exceptions -fno-rtti -DCPLUSPLUS ) | ||
set( SERVICE_ID "00111" ) | ||
set( AUTHOR_ID "KPRCA" ) | ||
add_compile_options( -O1 -g ) | ||
add_compile_options( -O1 -g -fpermissive -fms-extensions) | ||
set( VULN_COUNT "1" ) | ||
buildCB() |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
add_compile_options( -fno-exceptions -fno-rtti -DCPLUSPLUS ) | ||
set( SERVICE_ID "00097" ) | ||
set( AUTHOR_ID "KPRCA" ) | ||
add_compile_options( -O3 -g ) | ||
add_compile_options( -O3 -g -fpermissive -fms-extensions ) | ||
set( VULN_COUNT "1" ) | ||
buildCB() |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
set( VULN_COUNT "1" ) | ||
add_compile_options( -fno-exceptions -fno-rtti -DCPLUSPLUS ) | ||
set( override LDFLAGS "-nostdlib -static -Ttext=0x90000000" ) | ||
add_compile_options( -Oz -g ) | ||
add_compile_options( -Oz -g -fpermissive -fms-extensions) | ||
set( SERVICE_ID "00091" ) | ||
set( AUTHOR_ID "KPRCA" ) | ||
buildCB() |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
add_compile_options( -fno-exceptions -fno-rtti -DCPLUSPLUS ) | ||
set( SERVICE_ID "00075" ) | ||
set( AUTHOR_ID "KPRCA" ) | ||
add_compile_options( -O3 -g -DDISABLE_HEAP_GUARD ) | ||
add_compile_options( -O3 -g -DDISABLE_HEAP_GUARDi -fpermissive -fms-extensions ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there's an extraneous There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my bad |
||
set( VULN_COUNT "1" ) | ||
buildCB() |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
set( SERVICE_ID "00054" ) | ||
set( AUTHOR_ID "NRFIN" ) | ||
add_compile_options( -O0 -g -mno-sse ) | ||
add_compile_options( -O0 -g -mno-sse -msse2 -O3 ) | ||
set( VULN_COUNT "1" ) | ||
buildCB() | ||
buildSO() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to use Ninja, when it's available, but adding an option to force Makefiles seems like a good idea.
Could you add an option for overriding Ninja here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, ninja is fast, but not everyone uses them. Makefiles are just more widely adapted and a good tool to build challenges individually. I'll make it an option 👍