Fix #183 #184
Fix #183 #184
Conversation
jmattheis
force-pushed
the
issue_183
branch
from
f7494d1
to
3ea82aa
Compare
| if (ref.current) { | ||
| setHeight((old) => ({...old, [name]: ref.current!.getBoundingClientRect().height})); | ||
| const currentHeight = ref.current && ref.current.getBoundingClientRect().height; | ||
| if (currentHeight != null && currentHeight !== height) { |
There was a problem hiding this comment.
I've adjusted this, to check outside of the setState. The react docs weren't clear it guaranteed that setState with the same value doesn't force a rerender.
There was a problem hiding this comment.
It does skip rerendering: https://react.dev/reference/react/useState#setstate-caveats
If the new value you provide is identical to the current state, as determined by an Object.is comparison, React will skip re-rendering the component and its children. This is an optimization. Although in some cases React may still need to call your component before skipping the children, it shouldn’t affect your code.
There was a problem hiding this comment.
Although in some cases React may still need to call your component before skipping the children
Okay, then "reexecute" the compomennt instead of rerender, but yeah doesn't really matter as the new impl. behaves the same.
Fixes #183.
This only updates the state when the height has changed. This prevents the infinite render loop.