Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dashboard ingressroute #133

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: dashboard ingressroute #133

merged 2 commits into from
Feb 8, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Feb 7, 2024 •
edited
Loading

What does this PR do?

Allows to create a dynamic configuration resource, IngressRoute, to display Traefik Enterprise dashboard.

Motivation

See #130

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur mloiseleur added the kind/enhancement a new or improved feature. label Feb 7, 2024
@mloiseleur
Copy link
Contributor Author

@NEwa-05 Is this what you had in mind ?

darkweaver87
darkweaver87 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darkweaver87
darkweaver87 requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test it tomorrow but LGTM

NEwa-05
NEwa-05 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@NEwa-05 NEwa-05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep totally what I had in mind.
LGTM

darkweaver87
darkweaver87 requested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work. You need at least to enable api: {} in static config we provide by default.

@mloiseleur
Copy link
Contributor Author

Fixed and worked on my side with 628e99c

darkweaver87
darkweaver87 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NEwa-05
NEwa-05 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@NEwa-05 NEwa-05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NEwa-05
Copy link
Collaborator

NEwa-05 commented Feb 8, 2024

good catch on the API enablement within the static.

@traefiker traefiker merged commit 084b473 into traefik:master Feb 8, 2024
1 check passed
@mloiseleur mloiseleur deleted the feat/traefikee-dashboard branch February 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NEwa-05 NEwa-05 NEwa-05 approved these changes

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mloiseleur @NEwa-05 @darkweaver87 @traefiker