Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing Service spec fields #132

Merged
merged 2 commits into from
Feb 9, 2024
Merged

feat: add missing Service spec fields #132

merged 2 commits into from
Feb 9, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Feb 7, 2024 •
edited
Loading

What does this PR do?

Provides additionnal Service fields:

proxy:
  clusterIP:
  externalIPs:
  externalTrafficPolicy: 
  ipFamilyPolicy: SingleStack
  ipFamilies:
  loadBalancerClass:
  loadBalancerIP:
  loadBalancerSourceRanges:

Motivation

See #128. I added other fields so we should be good on this front.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur mloiseleur added the kind/enhancement a new or improved feature. label Feb 7, 2024
@mloiseleur
Copy link
Contributor Author

@maythamalfouadi Is this what is needed ?

@maythamalfouadi
Copy link

Yep! Thank you @mloiseleur

darkweaver87
darkweaver87 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

traefikee/values.yaml Show resolved Hide resolved
@traefiker traefiker merged commit 8fba4e1 into traefik:master Feb 9, 2024
1 check passed
@mloiseleur mloiseleur deleted the feat/externalTrafficPolicy branch February 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mloiseleur @maythamalfouadi @darkweaver87 @traefiker