feat: TLSOption #131
Merged
feat: TLSOption #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
added
kind/enhancement
|
@maythamalfouadi Is this what is needed ? |
|
Yep! Thank you @mloiseleur ! |
darkweaver87
requested changes
Feb 8, 2024
There was a problem hiding this comment.
You may test additional values that default. It doesn't work. Test with the example you provided.
Error: UPGRADE FAILED: failed to create resource: TLSOption.traefik.io "customOptions" is invalid: metadata.name: Invalid value: "customOptions": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
|
Good catch ! I fixed the example with 2e3c787 |
traefiker
force-pushed
the
feat/tlsoptions
branch
from
2e3c787
to
13d7417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows to create dynamic config resources:
TLSOption.Motivation
See #129
More
make testand all the tests passed