This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
feat: remove sidecar mode #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkweaver87
approved these changes
Mar 18, 2024
mloiseleur
approved these changes
Mar 19, 2024
mloiseleur
reviewed
Mar 19, 2024
Comment on lines
68
to
69
| - contains: | ||
| path: spec.template.spec.containers[0].args |
There was a problem hiding this comment.
Suggested change
| - contains: | |
| path: spec.template.spec.containers[0].args |
mloiseleur
reviewed
Mar 19, 2024
| - contains: | ||
| path: spec.template.spec.containers[0].args | ||
| content: ic | ||
| content: --entrypoints.metrics.address=:9100 |
There was a problem hiding this comment.
Suggested change
| content: --entrypoints.metrics.address=:9100 |
mloiseleur
reviewed
Mar 19, 2024
There was a problem hiding this comment.
@mmatur I have a suggestion on the test with --entrypoints.metrics.address=:9100.
With ic, it was useful to check that this mandatory parameter where set.
This entrypoint metrics address it not mandatory, so I suggest to remove it.
jspdown
approved these changes
Apr 9, 2024
mmatur
added
status/3-needs-merge
and removed
contributor/waiting-for-corrections
status/2-needs-review
labels
traefiker
force-pushed
the
feat/remove-sidecar-mode
branch
from
8b813d3
to
9f6d72c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes sidecar mode
Motivation
Related to https://github.com/traefik/hub-issues/issues/1125
More
make testand all the tests passed