This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
fix: Service annotations indent #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEwa-05
added
kind/bug/fix
mloiseleur
changed the title
mloiseleur
approved these changes
Jan 24, 2024
darkweaver87
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
LGTM, @NEwa-05 do you agree with the modified tests ?
With your patch:
### Chart [ traefik-hub ] ./traefik-hub
PASS admission-controller test traefik-hub/tests/admission-controller_test.yaml
PASS cluster-role-binding tests traefik-hub/tests/cluster-role-binding_test.yaml
PASS config-map labels test traefik-hub/tests/common_test.yaml
PASS deployment tests traefik-hub/tests/deployment_test.yaml
PASS HPA tests traefik-hub/tests/hpa_test.yaml
PASS IngressClass tests traefik-hub/tests/ingress-class_test.yaml
PASS service-account tests traefik-hub/tests/service-account_test.yaml
PASS service tests traefik-hub/tests/service_test.yaml
Charts: 1 passed, 1 total
Test Suites: 8 passed, 8 total
Tests: 55 passed, 55 total
Snapshot: 0 passed, 0 total
Time: 2.294337379sWithout it:
### Chart [ traefik-hub ] ./traefik-hub
PASS admission-controller test traefik-hub/tests/admission-controller_test.yaml
PASS cluster-role-binding tests traefik-hub/tests/cluster-role-binding_test.yaml
PASS config-map labels test traefik-hub/tests/common_test.yaml
PASS deployment tests traefik-hub/tests/deployment_test.yaml
PASS HPA tests traefik-hub/tests/hpa_test.yaml
PASS IngressClass tests traefik-hub/tests/ingress-class_test.yaml
PASS service-account tests traefik-hub/tests/service-account_test.yaml
FAIL service tests traefik-hub/tests/service_test.yaml
- should set service annotations and extraLabels
Error: yaml: line 4: did not find expected key
Charts: 1 failed, 0 passed, 1 total
Test Suites: 1 failed, 7 passed, 8 total
Tests: 1 failed, 1 errored, 54 passed, 55 total
Snapshot: 0 passed, 0 total
Time: 2.28413652s
Error: plugin "unittest" exited with error
|
Agree with your change, LGTM then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with whitespace not being chomped when adding annotation from the values.
More
make testand all the tests passedAdapted the service annotations template nothing to change at the test level
Fixes: #77