Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

feat: customizable Service ports #53

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Nov 17, 2023

What does this PR do?

Makes Service ports customizable.

Motivation

It can be useful on premise or with local setup, using kind.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Collaborator

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 30734bd into traefik:main Nov 20, 2023
1 check passed
@mloiseleur mloiseleur deleted the feat/node-port branch November 20, 2023 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants