Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/wgpu/repeat #1068

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Feat/wgpu/repeat #1068

merged 2 commits into from
Dec 14, 2023

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Dec 14, 2023

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

In #1049 Repeat was a bottleneck

Changes

Made a wgpu kernel for repeat operation, so we don't need to call many slice_assign kernels

Testing

Tests for the kernel in several dims, a larger one that exceeds the workgroup size, and tests for int and bool versions.

@louisfd louisfd mentioned this pull request Dec 14, 2023
1 task
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2ca1fd5) 85.54% compared to head (99399f5) 85.59%.

Files Patch % Lines
burn-wgpu/src/kernel/index/repeat.rs 98.97% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   85.54%   85.59%   +0.04%     
==========================================
  Files         508      509       +1     
  Lines       54019    54161     +142     
==========================================
+ Hits        46211    46357     +146     
+ Misses       7808     7804       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 4608cd9 into main Dec 14, 2023
12 checks passed
@nathanielsimard nathanielsimard deleted the feat/wgpu/repeat branch December 14, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants