Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository層のテストを消す #679

Merged
merged 1 commit into from
Jun 18, 2024
Merged

repository層のテストを消す #679

merged 1 commit into from
Jun 18, 2024

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented Jun 17, 2024

ORMを生SQLに書き替えてモックしており保守性が低いのと現状のintegration_tests/repositoryと目的が被っているので消したいです

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.79%. Comparing base (e961e64) to head (0e1e884).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #679       +/-   ##
===========================================
- Coverage   61.34%   32.79%   -28.55%     
===========================================
  Files          54       54               
  Lines        4312     4312               
===========================================
- Hits         2645     1414     -1231     
- Misses       1606     2866     +1260     
+ Partials       61       32       -29     
Flag Coverage Δ
integration 32.79% <ø> (-28.55%) ⬇️
unit 32.79% <ø> (-28.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiyp

@ras0q ras0q merged commit b12e3c6 into main Jun 18, 2024
10 of 11 checks passed
@ras0q ras0q deleted the remove/sql-mock-test branch June 18, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants