Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/chapter2_sec2 #146

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Fix/chapter2_sec2 #146

merged 5 commits into from
Jul 13, 2024

Conversation

mathsuky
Copy link
Contributor

本当に軽微な修正をしましたので，確認していただけると幸いです:pray:

Pugma
Pugma reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://router.vuejs.org/guide/essentials/dynamic-matching.html#Catch-all-404-Not-found-Route
を参考に
https://github.com/traPtitech/naro-text/pull/146/files#diff-183fb2be3fbb3c9d315928235af7d467a7c8327089ad674bdd8776753fc7d29dL17-L19
のpathマッチングの部分の最後に*をつけてほしいです！

@mathsuky mathsuky requested a review from Pugma July 13, 2024 02:38
@mathsuky
Copy link
Contributor Author

修正しました:kansya:

Pugma
Pugma requested changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vue-routerの設定ページでまだパスの正規表現が直っていない部分がありそうです
修正をお願いします:pray:

@mathsuky
Copy link
Contributor Author

:dekadeka::gomen::pray_shake:

@mathsuky mathsuky requested a review from Pugma July 13, 2024 04:46
@mathsuky
Copy link
Contributor Author

今度は反省して一括置換したので大丈夫だと思います...:pray:

Pugma
Pugma approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見た感じオッケーです！
ルートパスマッチングの修正もありがとうございました:arigato:

@mathsuky mathsuky merged commit 10dbc0e into main Jul 13, 2024
3 checks passed
@mathsuky mathsuky deleted the fix/chapter2_sec2 branch July 13, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pugma Pugma Pugma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathsuky @Pugma