Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React編のところの練習問題のスタイルをちょっと修正 #133

Closed
wants to merge 1 commit into from
Closed

React編のところの練習問題のスタイルをちょっと修正 #133

wants to merge 1 commit into from

Conversation

cp-20
Copy link
Contributor

@cp-20 cp-20 commented May 12, 2024

@mehm8128 :doudesuka:

mehm8128
mehm8128 reviewed May 12, 2024
View reviewed changes
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR出してくれてあれなのですが、
https://github.com/traPtitech/naro-text#%E8%A8%98%E5%85%A5%E3%81%AE%E6%B3%A8%E6%84%8F%E7%82%B9

練習問題は heading で区切って、container は使用しない

というルールになってるのでこのままでいきたいです🙏(あと基本Vue編を直す形にしてるので、直すとしたらVue編も一緒に直してもらえると助かります)

@cp-20
Copy link
Contributor Author

cp-20 commented May 12, 2024

そうなのか、ごめんなさい

@cp-20 cp-20 closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehm8128 mehm8128 mehm8128 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-20 @mehm8128