Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-export] Add new option for default height for query editor #659

Open
wants to merge 1 commit into
base: releaseCandidate
Choose a base branch
from

Conversation

sqone2
Copy link

@sqone2 sqone2 commented Nov 22, 2024

Describe your changes

Ability to set a default height for the data export query editor so the user does not have to always adjust the size manually.

Issue ticket number and link

Issue: #656

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@sqone2
Copy link
Author

sqone2 commented Nov 26, 2024

@tprouvot I had another thought with this one, what if instead of having an option to set the default height, when the user resizes the editor we silently capture the height and write it to local storage?

Let me know which approach sounds better to you 😊

@tprouvot tprouvot changed the title added logic for setting default height for data export query editor [data-export] Add new option for default height for query editor Nov 26, 2024
@tprouvot
Copy link
Owner

I like the approach but I think it can be disturbing if not explicitly announced.
What if the option is just a toggle to let users if they want to save the last query input height ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants