Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dark mode UI v2 #309

Open
wants to merge 111 commits into
base: releaseCandidate
Choose a base branch
from

Conversation

Astisme
Copy link

@Astisme Astisme commented Feb 15, 2024

Describe your changes

Complete overhaul to implement dark mode on every page.
This inlcudes the following:

  • Ability to switch to light/dark mode from within the popup

  • Ability to switch to light/dark mode from the options page

  • Ability to pick between default and accent mode form within the options page

  • Synchronization of theme & accent between any inspector page and any other inspector page (including popup)

  • Load of page with the latest theme and accent (fast-theme.js)

  • New styling for inspector button (need inspector.css in the manifest) when theme != light && accent != default

While I was working on CSS,

  • Found some duplicated entries which I've deleted for easier code readability
  • Stumbled upon a fix for images on the export page to work both on Chrome and Firefox

While I was trying to test on Firefox,

  • Fixed the error which was coming up with links.js not being recognized as a module (removed from the manifest and renamed to links.mjs)
  • Updated the readme.md with the newest command for the sf cli.
  • Found an issue with deploying the Account Settings for relating Accounts and Contacts (this needs fixing)

Issue ticket number and link

Issue #64

Checklist before requesting a review

  • I have read and understand the Contributions section
  • Target branch is releaseCandidate and not master
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

tprouvot and others added 30 commits April 21, 2023 12:11
…n for options main page with popup (and viceversa)
@tprouvot
Copy link
Owner

Hi @Astisme,
Any updates on this PR ?
Do you have any blocking points ?

@Astisme
Copy link
Author

Astisme commented Jul 10, 2024

Hi yes, I had a little bit of an issue tackling the last points
but the main issue has been not having enough spare time to work on this.
I hope to be able to work on this during the next week

@Astisme
Copy link
Author

Astisme commented Sep 30, 2024

With these commits, I've concluded my development.
I'll only merge the conflicts from now on.

@Astisme
Copy link
Author

Astisme commented Oct 1, 2024

  • I reviewed every page in every new color-scheme and color-accent on Chrome
  • I reviewed every page in every new color-scheme and color-accent on Firefox
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions

Copy link
Author

@Astisme Astisme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged and checked

@Astisme
Copy link
Author

Astisme commented Oct 28, 2024

@tprouvot I think I've found an issue currently on the live version (which is breaking the test-framework)
image
This picture comes from the Dev Ed org I've set up to test my changes but it's from the live version of the extension.
Could you please take a look at this when you get a chance?

@tprouvot
Copy link
Owner

Hi @Astisme ,
Yes I remember this one, I'll definitely take a look

@Astisme
Copy link
Author

Astisme commented Nov 7, 2024

ok, that's all.
feel free to comment

@tprouvot
Copy link
Owner

tprouvot commented Nov 8, 2024

Hi @Astisme,
Thanks for the updates, I have few remarks:

  • I prefer that the theme of reloaded stays in default mode and let users decide if they want to switch to dark theme or not
  • The option 'Match Theme to MacOS Appearance' does not work when disabling the option
  • We still have lots of UI difference with the existing version (you can install beta version and keep the local version to compare UI)

Popup, lots of differences in REST Explore page, Event Monitor, Field Creator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants