Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAPI: Fix intermediate self signed certificate. #2739

Conversation

JuergenReppSIT
Copy link
Member

@JuergenReppSIT JuergenReppSIT commented Dec 26, 2023

If a certificate which is downloaded from the uri defined in the EK certificate is self signed it can't be verified. It will not be stored in the certificate store. Self signed certificates have to be defined in the list of root certificates of FAPI.
Further Nuvoton root certificates TPM Root CA 1210 and 2112 are added.
Fixes #2738

If a certificate which is downloaded from the uri defined
in the EK certificate is self signed it can't be verified.
It will not be stored in the certificate store. Self
signed certificates have to be defined in the list of
root certificates of FAPI.
Fixes tpm2-software#2738

Signed-off-by: Juergen Repp <[email protected]>
Nuvoton TPM Root CA 1210 and 2112 are added.

Signed-off-by: Juergen Repp <[email protected]>
@JuergenReppSIT JuergenReppSIT force-pushed the fapi-fix-self-signed-certificate branch from 5124f33 to 25cb22c Compare December 31, 2023 09:23
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (28d6850) 82.55% compared to head (25cb22c) 82.55%.

Files Patch % Lines
src/tss2-fapi/ifapi_curl.c 76.47% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2739   +/-   ##
=======================================
  Coverage   82.55%   82.55%           
=======================================
  Files         369      369           
  Lines       43149    43156    +7     
=======================================
+ Hits        35620    35626    +6     
- Misses       7529     7530    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasFuchsTPM AndreasFuchsTPM merged commit f248a07 into tpm2-software:master Jan 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tss2_provision failed due to verifying EK certificate
2 participants