Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAPI: Enable importing of private OSSL keys. #2727

Merged

Conversation

JuergenReppSIT
Copy link
Member

A private OSSL PEM key now can be imported under a parent key in the FAPI keystore.

Signed-off-by: Juergen Repp [email protected]

@JuergenReppSIT JuergenReppSIT marked this pull request as draft December 5, 2023 22:10
@JuergenReppSIT JuergenReppSIT force-pushed the fapi-import-ossl-key branch 4 times, most recently from 4d2f49f to 7e81217 Compare December 10, 2023 18:02
A private OSSL PEM key now can be imported under a parent key in
the FAPI keystore.
Integration tests where OSSL RSA and ECC keys are imported are
added.

Signed-off-by: Juergen Repp <[email protected]>
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (182b027) 82.59% compared to head (bc9186a) 82.61%.

Files Patch % Lines
src/tss2-fapi/fapi_crypto.c 79.76% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2727      +/-   ##
==========================================
+ Coverage   82.59%   82.61%   +0.02%     
==========================================
  Files         369      369              
  Lines       43124    43249     +125     
==========================================
+ Hits        35619    35731     +112     
- Misses       7505     7518      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuergenReppSIT JuergenReppSIT marked this pull request as ready for review January 10, 2024 15:38
@AndreasFuchsTPM AndreasFuchsTPM merged commit e0dd86e into tpm2-software:master Jan 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants