tctildr: turn tctildr into a tcti #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joholl
force-pushed
the
tctildr-tcti
branch
2 times, most recently
from
da229c0 to
fe4011d
Compare
Signed-off-by: Johannes Holland <[email protected]>
Add the Tss2_Tcti_Info symbol to tctildr, including a compliant Tss2_Tcti_TctiLdr_Init() function. Signed-off-by: Johannes Holland <[email protected]>
Signed-off-by: Johannes Holland <[email protected]>
The tctildr has a different file name than other tctis. Normal tctis: * libtss2-tcti-<name>.so Tctildr: * libtss2-tctildr.so Enable loading the tctildr tcti module. Signed-off-by: Johannes Holland <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2695 +/- ##
==========================================
- Coverage 82.60% 82.59% -0.01%
==========================================
Files 368 368
Lines 43001 43024 +23
==========================================
+ Hits 35519 35536 +17
- Misses 7482 7488 +6
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tctildr is almost a tcti. I stumbled upon that when I wanted to create an abstraction for tctis in Rust.
Tss2_Tcti_Infosymbol which enables dynamic loadingSo I added the init function and the symbol. Technically it is a tcti now, so you can load the tctildr by specifying its path now:
tpm2 startup -c -T "/path/to/libtss2-tctildr.so"Unfortunately, it does not keep to the
libtss2-tcti-<name>.soconvention, so I added a commit which enables loading by just passingtctildrand the loading mechanism will trylibtss2-<name>.soas well.tpm2 startup -c -T "tctildr"You might ask yourself: why would I want tctildr to be loadable? No idea, but there is no harm in it... Btw, I also refactored the code for loading, so it is less chunky.