Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.am: Fix build without pandoc #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barsnick
Copy link

When building from a tarball, pre-created man pages are preset. Yet make clean clobbers them, leaving their target directory intact. Therefore, the next configure call will try to build man pages even if pandoc isn't available.

Fix this by cleaning the man pages only if they can be recreated by the presence of pandoc.

Fixes #284

barsnick added a commit to chargebyte/meta-chargebyte-distro that referenced this pull request Sep 19, 2024
This fixes failed attempts to build the man pages even tough pandoc is not
present.

Fixes tpm2-software/tpm2-tss-engine#284, with
patch from tpm2-software/tpm2-tss-engine#285.

Signed-off-by: Moritz Barsnick <[email protected]>
Copy link
Member

@AndreasFuchsTPM AndreasFuchsTPM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Signed-of-by tag

@barsnick
Copy link
Author

Please add a Signed-of-by tag

I have no idea why the DCO check fails to see it. It's been there all along.

@barsnick
Copy link
Author

I have no idea why the DCO check fails to see it.

Ah, I got it. It needs to be identical to the author.

When building from a tarball, pre-created man pages are preset. Yet `make
clean` clobbers them, leaving their target directory intact. Therefore, the
next configure call will try to build man pages even if pandoc isn't
available.

Fix this by cleaning the man pages only if they can be recreated by the
presence of pandoc.

Fixes tpm2-software#284

Signed-off-by: Moritz Barsnick <[email protected]>
@barsnick barsnick force-pushed the fix-build-without-pandoc branch from d5b9b97 to c345381 Compare October 11, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tarball: building without pandoc fails after make clean; configure
2 participants