-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test eventlog: fix check eventlog.sh if efivar.h exists #3304
test eventlog: fix check eventlog.sh if efivar.h exists #3304
Conversation
a08f85e
to
c3a814a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3304 +/- ##
=======================================
Coverage 76.53% 76.53%
=======================================
Files 173 173
Lines 23663 23663
=======================================
Hits 18110 18110
Misses 5553 5553 ☔ View full report in Codecov by Sentry. |
62b9b93
to
c570534
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should instead make sure that the outputs are always the same, no matter if evivar.h is here or not.
So if I understand this correctly:
@JuergenReppSIT @williamcroberts Thoughts ? |
@AndreasFuchsTPM @williamcroberts none of the alternatives is really good. I would prefer the one with the CML option --pretty |
@JuergenReppSIT or @AndreasFuchsTPM looks like FreeBSD in Cirrus is unhappy with:
Have you seen this before? If so what's the fix? update the tpm simulator binary? |
If efivar.h exist a pretty print function for the DevicePath is executed. Therefore two yaml test files are needed for the bin test file uefiservices. Fixes tpm2-software#3302. Signed-off-by: Juergen Repp <[email protected]>
c570534
to
3bd92de
Compare
@williamcroberts This problem was fixed with #3322. I didn't rebase the PR because I wanted to hear your opinion to the pretty print problem first. |
We just leave the behavior as is. While not desirable, we will fix for 6.0.0. I removed breaking change, because this isn't a breaking change. |
If efivar.h exist a pretty print function for the DevicePath is executed. Therefore two yaml test files are needed for the bin test file uefiservices.
Fixes #3302.
Signed-off-by: Juergen Repp [email protected]