-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mypy per module #560
Open
whooo
wants to merge
3
commits into
tpm2-software:master
Choose a base branch
from
whooo:mypy-per-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mypy per module #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [commit][1] in libtpms setting auth values/policies for PCRs are no longer supported. [1]: stefanberger/libtpms@af4fc0e Signed-off-by: Erik Larsson <[email protected]>
whooo
force-pushed
the
mypy-per-module
branch
from
January 17, 2024 20:23
8c98bb3
to
49f20a7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 91.57% 90.86% -0.72%
==========================================
Files 17 17
Lines 7017 7101 +84
Branches 1012 1032 +20
==========================================
+ Hits 6426 6452 +26
- Misses 418 457 +39
- Partials 173 192 +19 ☔ View full report in Codecov by Sentry. |
whooo
force-pushed
the
mypy-per-module
branch
from
January 17, 2024 20:34
49f20a7
to
e5e2de2
Compare
whooo
force-pushed
the
mypy-per-module
branch
7 times, most recently
from
January 18, 2024 17:55
20ca8e3
to
b1da22e
Compare
whooo
force-pushed
the
mypy-per-module
branch
from
January 19, 2024 12:19
e6c090f
to
cfe4af4
Compare
whooo
force-pushed
the
mypy-per-module
branch
from
January 20, 2024 09:16
28bbc65
to
d7a1d02
Compare
whooo
force-pushed
the
mypy-per-module
branch
2 times, most recently
from
January 21, 2024 14:57
6b2d85a
to
5d007d9
Compare
RSAPrivateNumbers was moved to a rust implementation in 42.0.1. So inheritance is no longer possible, so turn the class into a wrapper instead of a subclass. Fixes tpm2-software#561 Signed-off-by: Erik Larsson <[email protected]>
whooo
force-pushed
the
mypy-per-module
branch
3 times, most recently
from
January 28, 2024 18:14
3ca802d
to
f1efb36
Compare
Ignore the encoding module for now, waiting for the tools support to be removed. Signed-off-by: Erik Larsson <[email protected]>
whooo
force-pushed
the
mypy-per-module
branch
from
January 28, 2024 18:29
f1efb36
to
a3b354e
Compare
@whooo what's the overarching point of these patches? It was lost on me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.