Fix mypy checking #472
Draft
Fix mypy checking #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 21, 2022 15:24
mypy is a static analyzer for Python using the Python3 typehints as meta data. See the below link for more information: - https://mypy.readthedocs.io/en/stable/index.html Signed-off-by: William Roberts <[email protected]>
Signed-off-by: William Roberts <[email protected]>
Fixes: test/test_fapi.py:84: error: Incompatible types in assignment (expression has type "bytes", variable has type "Hash") test/test_fapi.py:85: error: Incompatible return value type (got "Hash", expected "bytes") Signed-off-by: William Roberts <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 88.17% 88.16% -0.01%
==========================================
Files 18 18
Lines 6630 6627 -3
Branches 972 972
==========================================
- Hits 5846 5843 -3
Misses 639 639
Partials 145 145
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Drop the nuclear option of --ignore-missing-imports and add a more targeted approach to ignoring libraries without type information. This just makes sure that tpm2-pytss internal modules themselves don't accidentally get ignored. Signed-off-by: William Roberts <[email protected]>
added 2 commits
November 21, 2022 15:56
Signed-off-by: William Roberts <[email protected]>
Signed-off-by: William Roberts <[email protected]>
|
This pull request introduces 2 alerts when merging ba081d5 into 8014ee9 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
williamcroberts
force-pushed
the
fix-mypy-checking
branch
from
ba081d5 to
b6e4694
Compare
Signed-off-by: William Roberts <[email protected]>
williamcroberts
force-pushed
the
fix-mypy-checking
branch
from
b6e4694 to
336aa16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.