Support for non-Float64 eltypes when using ForwardDiff #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Dec 24, 2022
devmotion
reviewed
Dec 24, 2022
devmotion
reviewed
Dec 24, 2022
tpapp
requested changes
Dec 24, 2022
There was a problem hiding this comment.
Thanks for this PR, I am happy to merge once suggestions by @devmotion are implemented.
|
@devmotion: I am on holiday and will only check my emails occasionally in the next week or so, feel free to merge this and tag a release once your suggestions are implemented, so that TuringLang/AdvancedHMC.jl#301 is not held up. |
Co-authored-by: David Widmann <[email protected]>
|
Great! Made the changes:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tests for example + things like
also works.