-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a progress bar based on ProgressMeter.jl
#136
Conversation
Alright, this is ready for review now @tpapp |
Thanks. I am very busy now but will try to do it soon. Feel free to bump this if I don't get to it within a week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just requested some trivial changes. Thanks for adding this nice feature!
I think I've addressed all the changes! You will also notice that I have now removed the Right now, we have separate progress bars for warmup and MCMC. Long-term, I think the best solution will be to figure out how to have a single progress bar for both warmup and MCMC. This will require some more info, e.g. #141 Once we implement that feature, the So I think it's best to right now remove the |
Thanks, I think this is the best solution for now. I am merging this, but if that is OK with you I will wait for JuliaNLSolvers/Optim.jl#863 to resolve before tagging a new release. If you need that before, just let me know. |
Sounds good to me, there's no time pressure on my part. |
Fixes #135
This pull request adds the
ProgressMeterReport
, which uses theProgressMeter.jl
package to display a progress bar.To use this reporter, simply set the
reporter
keyword argument when callingmcmc_with_warmup
:cc: @tpapp