Add error message, if returned search HTML does not contain required elements #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This change adds a check, if the returned HTML from non-SERP scrapers like scraping robot or proxy contains the expected base structure.
This improves the problem from #272 where parsing fails on a bot-protection popup and returns position = 0.
The error that no results can be parsed on bot-protection still persists, but serpbear will show an error instead of dropping position to zero.
Behavior
Screenshot of changed version on error
Note, that the drop in the position graph was generated due to #272 and should not occur anymore with this change.
Log of changed version on error