add component to display contributors #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
requested changes
Nov 27, 2024
src/lib/constants/constants.ts
Outdated
Comment on lines
710
to
735
| export const repoNames = [ | ||
| 'torrust-tracker', | ||
| 'torrust-compose', | ||
| 'torrust-website', | ||
| 'torrust-index', | ||
| 'torrust-index-gui', | ||
| 'torrust-bencode-online', | ||
| 'torrust-demo', | ||
| 'bittorrent-infrastructure-project', | ||
| 'bencode2json', | ||
| 'torrust-installer', | ||
| 'bittorrent-primitives', | ||
| 'json2bencode', | ||
| 'torrust-bencode2json', | ||
| 'torrust-index-api-lib', | ||
| 'torrust-index-types-lib', | ||
| 'torrust-hash2torrent', | ||
| 'torrust-index-gui-user-guide', | ||
| 'containerizing-rust-apps-examples', | ||
| 'torrust-serde-bencode-archive', | ||
| 'torrust-index-archive', | ||
| 'torrust-parse-torrent', | ||
| 'torrents-importer-sample', | ||
| 'torrust-documentation', | ||
| 'torrust-docker' | ||
| ]; |
There was a problem hiding this comment.
Hi @grmbyrn I guess you can also get the list of repos from the API.
|
ACK 158a94e |
josecelano
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Hi @grmbyrn, when you run it locally you get this error:
➜ Local: http://localhost:5173/
➜ Network: http://192.168.1.37:5173/
➜ Network: http://192.168.1.33:5173/
➜ press h + enter to show help
Fetching data from API
Rate limit: 60, Remaining: 0 10:46 AM
Rate limit resets at: Mon Dec 02 2024 10:53:01 GMT+0000 (Western European Standard Time)
Failed to fetch from https://api.github.com/orgs/torrust/repos: rate limit exceeded
Error: Failed to fetch from https://api.github.com/orgs/torrust/repos
at Module.fetchWithCache (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/src/lib/utils/cache.ts:40:9)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async load (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/src/routes/(home)/+page.server.ts:13:16)
at async Module.load_server_data (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/node_modules/@sveltejs/kit/src/runtime/server/page/load_data.js:61:17)
at async eval (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/node_modules/@sveltejs/kit/src/runtime/server/page/index.js:140:13)
Fetching data from API
Rate limit: 60, Remaining: 0 10:46 AM
Rate limit resets at: Mon Dec 02 2024 10:53:01 GMT+0000 (Western European Standard Time)
Failed to fetch from https://api.github.com/orgs/torrust/repos: rate limit exceeded
Error: Failed to fetch from https://api.github.com/orgs/torrust/repos
at Module.fetchWithCache (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/src/lib/utils/cache.ts:40:9)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async load (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/src/routes/(home)/+page.server.ts:13:16)
at async Module.load_server_data (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/node_modules/@sveltejs/kit/src/runtime/server/page/load_data.js:61:17)
at async Promise.all (index 2)
at async Module.render_data (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/node_modules/@sveltejs/kit/src/runtime/server/data/index.js:99:17)
at async resolve (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/node_modules/@sveltejs/kit/src/runtime/server/respond.js:436:17)
at async Module.respond (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/node_modules/@sveltejs/kit/src/runtime/server/respond.js:322:20)
at async file:///home/josecelano/Documents/git/committer/me/github/torrust/torrust-website/node_modules/@sveltejs/kit/src/exports/vite/dev/index.js:524:22
I guess it's because I restarted the server and the data is not in the store anymore. I think we should not show the contributors list in that case.
I would also add the list to the community page.
Finally, I would remove console logs for production, especially when it's only for debugging.
TODO
- Fix problem when get too many requests error but the store is empty. I think we could have a default value in this case with the list of contributor. We can update that default value from time to time.
- Remove console logs
- Add the list to the community page
Hi @josecelano for the request error, I made an array of objects for the contributors and put it in |
josecelano
requested changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
routes/(home)/+page.server.ts, fetch contributors data from GitHub API to use in Torrust repos.Contributortype for data coming from GitHub API and store it in'$lib/utils/types'to be imported'$lib/constants/constants'to be imported and reactively mapped over together with a baseURL.envand store it inconst token = import.meta.env.VITE_GITHUB_TOKEN;to order to increase GitHub API rate limits.routes/(home)/+page.svelte, which passes it into componentContributors.sveltein order to loop over and display each contributor on the home page.On each of the
(pages)routes there wasn't responsiveness to make Table of Contents appear above the text on smaller screens and to the left on wider screens, so I added that to each.