#326: Add tower-http compression as middleware #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da2ce7
reviewed
Aug 26, 2023
| @@ -41,6 +41,7 @@ uuid = { version = "1", features = ["v4"] } | |||
| axum = "0.6.20" | |||
| axum-server = { version = "0.5", features = ["tls-rustls"] } | |||
| axum-client-ip = "0.4.1" | |||
| tower-http = { version= "0.4.3", features = ["full"] } | |||
There was a problem hiding this comment.
It would be nice not to include the full tower-http feature set, this will increase build times.
There was a problem hiding this comment.
Here are the different feature-sets to select from: https://github.com/tower-rs/tower-http/blob/master/tower-http/Cargo.toml#L55
There was a problem hiding this comment.
@da2ce7 You are absolutely right.
I have adjusted it. I will create a new pull-request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified:
I have added tower-http compression as middleware on both HTTP routers(API, Tracker HTTP).
All tests were run and were okay.