Skip to content

Commit

Permalink
Merge #1064: #1040: continue when finding errors
Browse files Browse the repository at this point in the history
a34f66e Fix #1040: `continue` when finding errors (abstralexis)

Pull request description:

  Fix the behaviour of UDP checks exiting on first fail (#1040). Was `break`ing instead of `continue`ing when iterating over each test.

ACKs for top commit:
  josecelano:
    ACK a34f66e

Tree-SHA512: 616c5671f2e6912fb7992794ca634d1402e7d4e712a5dbb5dab498ac67bbf622220f241d84f8ebc3129ba284dca587040a5cca2989023979d2068e458e5382e1
  • Loading branch information
josecelano committed Oct 17, 2024
2 parents cb9e345 + a34f66e commit 105dfc1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/console/clients/checker/checks/udp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub async fn run(udp_trackers: Vec<Url>, timeout: Duration) -> Vec<Result<Checks
Err(err) => {
checks.results.push((Check::Setup, Err(err)));
results.push(Err(checks));
break;
continue;
}
};

Expand All @@ -65,7 +65,7 @@ pub async fn run(udp_trackers: Vec<Url>, timeout: Duration) -> Vec<Result<Checks
Err(err) => {
checks.results.push((Check::Connect, Err(err)));
results.push(Err(checks));
break;
continue;
}
};

Expand Down

0 comments on commit 105dfc1

Please sign in to comment.