Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django 51 #251

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Update django 51 #251

merged 11 commits into from
Oct 18, 2024

Conversation

mark-meyer
Copy link
Contributor

Description

Please include a summary of the changes and which issue this relates to (if applicable).

Fixes # (issue)
Updates project to support Django 5.1

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good.
Made a suggestion to do a bit of tidy up while at it (Drop Django < 4.2, Python < 3.9)

pyproject.toml Outdated Show resolved Hide resolved
@mark-meyer
Copy link
Contributor Author

Thanks @zerolab — I've added this change. I'm not sure where you mean to drop Python 3.8 — I think Django 4.2 still supports Py3.8.

I did drop Django3.2 from the tox dependencies.

@zerolab
Copy link
Member

zerolab commented Oct 17, 2024

While Django 4.2 still supports it, Python 3.8 is no longer maintained - https://endoflife.date/python - so this is a good time to drop it

Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more suggestions

pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@mark-meyer
Copy link
Contributor Author

Thanks @zerolab - I also cleaned up some of the GitHub workflow to remove references to the removed toxenvs and updated the docs.

docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
@zerolab
Copy link
Member

zerolab commented Oct 17, 2024

Thank you @mark-meyer. a couple of more things then this is good to go 🙌🏼

Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Will leave the tests to run. Hopefully we can make a new release tomorrow (as it is end of the day for me, at least)

@zerolab zerolab merged commit 33a322c into torchbox:main Oct 18, 2024
10 checks passed
@dylan8902
Copy link

Hi @zerolab Is there anything blocking this being released now?

@zerolab
Copy link
Member

zerolab commented Nov 12, 2024

Unfortunately I do not have the power to make a release.

cc @thibaudcolas

@dylan8902
Copy link

@thibaudcolas Would you able to make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants