-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update django 51 #251
Update django 51 #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look good.
Made a suggestion to do a bit of tidy up while at it (Drop Django < 4.2, Python < 3.9)
Co-authored-by: Dan Braghiș <[email protected]>
Thanks @zerolab — I've added this change. I'm not sure where you mean to drop Python 3.8 — I think Django 4.2 still supports Py3.8. I did drop Django3.2 from the tox dependencies. |
While Django 4.2 still supports it, Python 3.8 is no longer maintained - https://endoflife.date/python - so this is a good time to drop it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more suggestions
Co-authored-by: Dan Braghiș <[email protected]>
Co-authored-by: Dan Braghiș <[email protected]>
Thanks @zerolab - I also cleaned up some of the GitHub workflow to remove references to the removed toxenvs and updated the docs. |
Thank you @mark-meyer. a couple of more things then this is good to go 🙌🏼 |
Co-authored-by: Dan Braghiș <[email protected]>
…imental. Co-authored-by: Dan Braghiș <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Will leave the tests to run. Hopefully we can make a new release tomorrow (as it is end of the day for me, at least)
Hi @zerolab Is there anything blocking this being released now? |
Unfortunately I do not have the power to make a release. |
@thibaudcolas Would you able to make a release? |
Description
Please include a summary of the changes and which issue this relates to (if applicable).
Fixes # (issue)
Updates project to support Django 5.1
Checklist