Support/wagtail 5.1 #3
Conversation
nickmoreton
force-pushed
the
support/wagtail-5.1
branch
from
490bd44
to
8e5e1bb
Compare
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read # to fetch code (actions/checkout) | ||
|
|
There was a problem hiding this comment.
Has the effect of cancelling previous running tests if new tests are requested.
| name: | | ||
| build (Python ${{ matrix.python-version }}, | ||
| Django ${{ matrix.django-version }}, | ||
| Wagtail ${{ matrix.wagtail-version }}), |
There was a problem hiding this comment.
Removed so that running tests have a more meaningful sidebar title. The title will now show the Python version been test in each job.
| python-version: ["3.8", "3.9", "3.10", "3.11"] | ||
| django-version: ["3.2", "4.1", "4.2"] | ||
| wagtail-version: ["4.1", "4.2", "5.0"] | ||
| exclude: | ||
| - python-version: "3.8" | ||
| django-version: "4.2" | ||
| - python-version: "3.9" | ||
| django-version: "4.2" | ||
| - python-version: "3.10" | ||
| django-version: "4.2" | ||
| - python-version: "3.11" | ||
| django-version: "3.2" | ||
| - python-version: "3.11" | ||
| wagtail-version: "4.1" | ||
| - python-version: "3.11" | ||
| wagtail-version: "4.2" | ||
| - django-version: "3.2" | ||
| wagtail-version: "5.0" |
There was a problem hiding this comment.
This isn't required when using tox-gh-actions. The test matrix is defined in the tox.ini file
| Django>=3.2, <4.3 | ||
| wagtail>=4.1, <5.2 |
There was a problem hiding this comment.
While i have made some changes here they are duplicates of some config in setup.py and don't seem to be used.
|
This all look great, I think your changes make it much clearer! |
|
Hi @nickmoreton , |
Wagtail 5.1 update
The only changes here are to update the test matrix and supported versions. The package should work OK with Wagtail v5.1