Wagtail 5.1 upgrades and test workflow update #3
Conversation
| # 'wagtail_modeladmin', # if Wagtail >=5.1; Don't repeat if it's there already | ||
| 'wagtail.contrib.modeladmin', # if Wagtail <5.1; Don't repeat if it's there already |
There was a problem hiding this comment.
I'm not sure what this means, sorry.
| # "wagtail_modeladmin", # if Wagtail >=5.1; Don't repeat if it's there already | ||
| "wagtail.contrib.modeladmin", # if Wagtail <5.1; Don't repeat if it's there already |
There was a problem hiding this comment.
Hi @nickmoreton ,
I based it on Jazzband's update here:
https://github.com/jazzband/wagtailmenus/pull/461/files#diff-e285c1b9901cd202e89d9f37e3249a6fee524a65428895e1a45fd062cc0f9acaR22-R23
Which is a resolution for this Wagtail 5.1 upgrade consideration: wagtail.contrib.modeladmin is deprecated
I updated the PR to actually replace the installed app depending on the Wagtail version.
b00c2b7
There was a problem hiding this comment.
Please note that this is not actually compatible with Wagtail 5.1!
The otp_form.html template includes an SVG logo that was deleted in wagtail/wagtail@ecb2126
I've done a quick 'n dirty fix on my fork here: techonomydev@7fe52ba but you may want to create proper fix because my fix breaks support for Wagtail 5.0 and older.
Hi @Stormheg , @ArnarTumi , Thanks! |
|
Your fix looks good @katdom13 👍 What would be even better is if you could add a test that checks if the otp form page renders okay without crashing. A smoke test. That way we will be alerted if Wagtail changes one if its internal template includes again. What do you think? |
nickmoreton
force-pushed
the
support/wagtail-51
branch
from
695027b
to
724d524
Compare
@ArnarTumi This has been rebased now on the maintainers master branch so |
nickmoreton
force-pushed
the
support/wagtail-51
branch
from
724d524
to
ef46a17
Compare
|
@katdom13 All good thanks and tested locally using the sandbox |
|
@Stormheg , @nickmoreton , |
Upstream PR: labd#227