Skip to content

Commit

Permalink
Wait for scope bindings to be set before initializing component modals.
Browse files Browse the repository at this point in the history
This ensures that component bindings are available in the $onInit callback of the component's lifecycle
This addresses the main issue brought up by dwmkerr#270
  • Loading branch information
DougKeller committed Sep 15, 2020
1 parent 3ddaf86 commit c15133f
Show file tree
Hide file tree
Showing 9 changed files with 123 additions and 24 deletions.
4 changes: 2 additions & 2 deletions dst/angular-modal-service.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dst/angular-modal-service.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dst/angular-modal-service.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c15133f

Please sign in to comment.