Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code style ala WordPress #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpeshev
Copy link
Contributor

@mpeshev mpeshev commented Sep 6, 2013

The plugin is great, but the styling doesn't comply with the WordPress coding conventions. Any way we can bring it closer for improved readability?

@topdown
Copy link
Owner

topdown commented Sep 6, 2013

Its they way I have been writing PHP for over 6 years, kinda stuck now.
Eg. Brackets on new lines, etc... Which I actually think is more readable than WordPress standards.

The biggest issue is I have my IDE setup for formatting to my style.
But I understand your request being that it is WordPress coding standard.

@mpeshev
Copy link
Contributor Author

mpeshev commented Sep 6, 2013

I understand the background story, not to mention that some languages (.NET platform ones and some C/C++ conventions) claim to use it. I'm more of a Java-convention person and try to keep some structure but either way the feedback is appreciated (I might also try to propose some filters or other small updates and checking with initial PRs today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants