PROD - Fixes to use v5 for challenge results instead of v2 #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkartunov
reviewed
Jan 11, 2024
| dispatch(a.loadResultsInit(ch.legacyId)); | ||
| dispatch(a.loadResultsDone(tokens, ch.legacyId, ch.track.toLowerCase())); | ||
| dispatch(a.loadResultsInit(ch.id)); | ||
| dispatch(a.loadResultsDone(ch.id)); |
There was a problem hiding this comment.
@jmgasper why are the other arguments loadResultsDone missing?
Is loadResultsDone moved to the react-lib and updated thus not to see it here?
There was a problem hiding this comment.
The tokens weren't used in the original call, and the track isn't necessary since we can now get that from the v5 challenge object response.
kkartunov
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PS-187