Apache 2 licensing and attribution #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Joshua! I was scrolling Github looking for Hue driver, and while scrolling, I noticed that you're using some of my MagicHome code in your project verbatim to my original writing in your project. This is fine—and it's completely fair game to use—but it's licensed under Apache 2 and requires attribution. Specifically, the imports, logDebug preferences and method, deviceIP preferences, parts of your commands ( '// 0 - 255' ), and parse, are verbatim to my original code. It looks like this is the only file affected, so I've made a PR with attribution added in hopes that you'll work with me in honoring the Apache 2 license listed in my drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joshua! I was scrolling Github looking for Hue driver, and while scrolling, I noticed that you're using some of my MagicHome code in your project verbatim to my original writing in your project.
This is fine—and it's completely fair game to use—but it's licensed under Apache 2 and requires attribution. Specifically, the imports, logDebug preferences and method, deviceIP preferences, parts of your commands ( '// 0 - 255' ), and parse, are verbatim to my original code.
It looks like this is the only file affected, so I've made a PR with attribution added in hopes that you'll work with me in honoring the Apache 2 license listed in my drivers.