[spark] Show create table display using paimon (apache#2460)

tongcheng-elong · Dec 7, 2023 · c7e8432 · c7e8432
1 parent 74f85ce
commit c7e8432
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/...-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkGenericCatalog.java b/...-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkGenericCatalog.java
@@ -180,7 +180,7 @@ public Table createTable(
             Transform[] partitions,
             Map<String, String> properties)
             throws TableAlreadyExistsException, NoSuchNamespaceException {
-        String provider = properties.get("provider");
+        String provider = properties.get(TableCatalog.PROP_PROVIDER);
         if (usePaimon(provider)) {
             return sparkCatalog.createTable(ident, schema, partitions, properties);
         } else {
@@ -284,7 +284,7 @@ public String name() {
     }
 
     private boolean usePaimon(String provider) {
-        return provider == null || "paimon".equalsIgnoreCase(provider);
+        return provider == null || SparkSource.NAME().equalsIgnoreCase(provider);
     }
 
     private T getSessionCatalog() {

diff --git a/paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkTable.java b/paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkTable.java
@@ -27,6 +27,7 @@
 import org.apache.spark.sql.connector.catalog.SupportsRead;
 import org.apache.spark.sql.connector.catalog.SupportsWrite;
 import org.apache.spark.sql.connector.catalog.TableCapability;
+import org.apache.spark.sql.connector.catalog.TableCatalog;
 import org.apache.spark.sql.connector.expressions.FieldReference;
 import org.apache.spark.sql.connector.expressions.IdentityTransform;
 import org.apache.spark.sql.connector.expressions.Transform;
@@ -108,10 +109,11 @@ public Map<String, String> properties() {
         if (table instanceof DataTable) {
             Map<String, String> properties =
                     new HashMap<>(((DataTable) table).coreOptions().toMap());
-            if (table.primaryKeys().size() > 0) {
+            if (!table.primaryKeys().isEmpty()) {
                 properties.put(
                         CoreOptions.PRIMARY_KEY.key(), String.join(",", table.primaryKeys()));
             }
+            properties.put(TableCatalog.PROP_PROVIDER, SparkSource.NAME());
             return properties;
         } else {
             return Collections.emptyMap();

diff --git a/paimon-spark/paimon-spark-common/src/test/java/org/apache/paimon/spark/SparkReadITCase.java b/paimon-spark/paimon-spark-common/src/test/java/org/apache/paimon/spark/SparkReadITCase.java
@@ -363,7 +363,6 @@ public void testShowCreateTable() {
                 .isEqualTo(
                         String.format(
                                 "[[%s"
-                                        + "USING paimon\n"
                                         + "PARTITIONED BY (b)\n"
                                         + "COMMENT 'tbl comment'\n"
                                         + "TBLPROPERTIES (\n"

diff --git a/...on-spark/paimon-spark-common/src/test/java/org/apache/paimon/spark/SparkReadTestBase.java b/...on-spark/paimon-spark-common/src/test/java/org/apache/paimon/spark/SparkReadTestBase.java
@@ -198,7 +198,7 @@ protected static void writeTable(String tableName, String... values) {
     // return of 'SHOW CREATE TABLE' excluding TBLPROPERTIES
     protected String showCreateString(String table, String... fieldSpec) {
         return String.format(
-                "CREATE TABLE paimon.default.%s (%s)\n",
+                "CREATE TABLE paimon.default.%s (%s)\nUSING paimon\n",
                 table,
                 Arrays.stream(fieldSpec).map(s -> "\n  " + s).collect(Collectors.joining(",")));
     }