add some log

tongcheng-elong · Dec 26, 2023 · 7f0188b · 7f0188b
1 parent 8a9d9c9
commit 7f0188b
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 15 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java b/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java
@@ -333,7 +333,7 @@ public WriterContainer<T> createWriterContainer(
         if (LOG.isDebugEnabled()) {
             LOG.debug("Creating writer for partition {}, bucket {}", partition, bucket);
         }
-
+        final long startTs = System.currentTimeMillis();
         Long latestSnapshotId = snapshotManager.latestSnapshotId();
         List<DataFileMeta> restoreFiles = new ArrayList<>();
         if (!ignorePreviousFiles && latestSnapshotId != null) {
@@ -347,6 +347,11 @@ public WriterContainer<T> createWriterContainer(
         RecordWriter<T> writer =
                 createWriter(partition.copy(), bucket, restoreFiles, null, compactExecutor());
         notifyNewWriter(writer);
+        LOG.info(
+                "Creating writer for partition {}, bucket {}, time {} ms",
+                partition,
+                bucket,
+                System.currentTimeMillis() - startTs);
         return new WriterContainer<>(writer, indexMaintainer, latestSnapshotId);
     }
 

diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreExpireImpl.java b/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreExpireImpl.java
@@ -164,8 +164,8 @@ public void expireUntil(long earliestId, long endExclusiveId) {
 
         endExclusiveId = Math.min(beginInclusiveId + expireLimit, endExclusiveId);
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug(
+        if (LOG.isInfoEnabled()) {
+            LOG.info(
                     "Snapshot expire range is [" + beginInclusiveId + ", " + endExclusiveId + ")");
         }
 
@@ -175,8 +175,8 @@ public void expireUntil(long earliestId, long endExclusiveId) {
         // deleted merge tree files in a snapshot are not used by the next snapshot, so the range of
         // id should be (beginInclusiveId, endExclusiveId]
         for (long id = beginInclusiveId + 1; id <= endExclusiveId; id++) {
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Ready to delete merge tree files not used by snapshot #" + id);
+            if (LOG.isInfoEnabled()) {
+                LOG.info("Ready to delete merge tree files not used by snapshot #" + id);
             }
             Snapshot snapshot = snapshotManager.snapshot(id);
             // expire merge tree files and collect changed buckets
@@ -197,8 +197,8 @@ public void expireUntil(long earliestId, long endExclusiveId) {
 
         // delete changelog files
         for (long id = beginInclusiveId; id < endExclusiveId; id++) {
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Ready to delete changelog files from snapshot #" + id);
+            if (LOG.isInfoEnabled()) {
+                LOG.info("Ready to delete changelog files from snapshot #" + id);
             }
             Snapshot snapshot = snapshotManager.snapshot(id);
             if (snapshot.changelogManifestList() != null) {
@@ -217,8 +217,8 @@ public void expireUntil(long earliestId, long endExclusiveId) {
         skippingSnapshots.add(snapshotManager.snapshot(endExclusiveId));
         Set<String> skippingSet = snapshotDeletion.manifestSkippingSet(skippingSnapshots);
         for (long id = beginInclusiveId; id < endExclusiveId; id++) {
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Ready to delete manifests in snapshot #" + id);
+            if (LOG.isInfoEnabled()) {
+                LOG.info("Ready to delete manifests in snapshot #" + id);
             }
 
             Snapshot snapshot = snapshotManager.snapshot(id);

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java b/paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java
@@ -54,6 +54,8 @@
 import org.apache.paimon.utils.Preconditions;
 import org.apache.paimon.utils.SnapshotManager;
 import org.apache.paimon.utils.TagManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.io.UncheckedIOException;
@@ -73,6 +75,7 @@
 public abstract class AbstractFileStoreTable implements FileStoreTable {
 
     private static final long serialVersionUID = 1L;
+    protected static final Logger LOG = LoggerFactory.getLogger(AbstractFileStoreTable.class);
 
     protected final FileIO fileIO;
     protected final Path path;
@@ -371,12 +374,17 @@ private Optional<TableSchema> tryTimeTravel(Options options) {
                 }
                 return Optional.empty();
             case FROM_TIMESTAMP:
-                Snapshot snapshot =
-                        StaticFromTimestampStartingScanner.timeTravelToTimestamp(
-                                snapshotManager(), coreOptions.scanTimestampMills());
-                if (snapshot != null) {
-                    long schemaId = snapshot.schemaId();
-                    return Optional.of(schemaManager().schema(schemaId).copy(options.toMap()));
+                try {
+                    Snapshot snapshot =
+                            StaticFromTimestampStartingScanner.timeTravelToTimestamp(
+                                    snapshotManager(), coreOptions.scanTimestampMills());
+                    if (snapshot != null) {
+                        long schemaId = snapshot.schemaId();
+                        return Optional.of(schemaManager().schema(schemaId).copy(options.toMap()));
+                    }
+                } catch (Exception ex) {
+                    LOG.warn("Get table schema from snapshot error,snapshot maybe expired");
+                    return Optional.empty();
                 }
                 return Optional.empty();
             default:

diff --git a/paimon-core/src/main/java/org/apache/paimon/utils/FileUtils.java b/paimon-core/src/main/java/org/apache/paimon/utils/FileUtils.java
@@ -25,6 +25,9 @@
 import org.apache.paimon.fs.Path;
 import org.apache.paimon.reader.RecordReader;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.util.ArrayList;
@@ -39,6 +42,8 @@ public class FileUtils {
 
     public static final ForkJoinPool COMMON_IO_FORK_JOIN_POOL;
 
+    private static final Logger LOG = LoggerFactory.getLogger(FileUtils.class);
+
     // if we want to name threads in the fork join pool we need all these
     // see https://stackoverflow.com/questions/34303094/
     static {
@@ -49,6 +54,7 @@ public class FileUtils {
                     worker.setName("file-store-common-io-" + worker.getPoolIndex());
                     return worker;
                 };
+        LOG.info("runtime availableProcessors:{}", Runtime.getRuntime().availableProcessors());
         COMMON_IO_FORK_JOIN_POOL =
                 new ForkJoinPool(Runtime.getRuntime().availableProcessors(), factory, null, false);
     }