fix: double quote array expansions to avoid re-splitting elements #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the deployment script, we identified an issue with the array expansion which could lead to unexpected behavior due to re-splitting of its elements.
Details:
${Files[@]}
. If any of its elements contained spaces or other special characters, they would be re-split into separate arguments."${Files[@]}"
.This adheres to the recommendation from ShellCheck warning
SC2068
, which advises double-quoting array expansions to prevent globbing and word splitting of individual elements. Not doing so can lead to unexpected behavior, especially when elements of the array contain spaces or special characters.Reference:
By applying this fix, we ensure the script behaves predictably and correctly, regardless of the content of the array elements.